[data grid] Fix grid overlay aligment with scroll for RTL #15072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romgrk @michelengelen please review the PR when you find sometime |
zannager
added
the
component: data grid
romgrk
approved these changes
Nov 4, 2024
|
Code LGTM, PR not tested (waiting for the docs deploy to complete), once that's ok we can merge it. |
|
Deploy preview: https://deploy-preview-15072--material-ui-x.netlify.app/ |
oliviertassinari
changed the title
|
I'm not sure, is the issue fixed? https://deploy-preview-15072--material-ui-x.netlify.app/x/react-data-grid/overlays/#no-rows-overlay Screen.Recording.2024-11-06.at.00.52.52.mov |
|
That's on chrome/macos? It works fine on chrome/linux: Screencast.from.2024-11-05.20-21-32.mp4 |
|
@romgrk This was with macOS/Chrome 130. I have tried it on Windows/Chrome 130. It's broken too. Now, your video is in LTR so it doesn't count 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to address #14289
Preview: https://deploy-preview-15072--material-ui-x.netlify.app/x/react-data-grid/overlays/